hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11746) rewrite test-patch.sh
Date Tue, 31 Mar 2015 17:14:53 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388861#comment-14388861
] 

Allen Wittenauer commented on HADOOP-11746:
-------------------------------------------

Found two bugs this morning with the current patch, both of them minor:
* http mode doesn't work because I forgot how regexp match worked in bash on that line. ;)
* in jenkins mode, we shouldn't try to cp the support dir lib if it doesn't exist.

BTW, there's a good chance I've already fixed the race that [~kasha] is hitting in YARN-3412.
 findmodules (which is the one that determines which pom.xml files to use for tests) was one
of the first parts of the old code that I saw that scared me a bit.  It features a hard-coded
path that isn't tied to the current patch run directory at all and is global to the box. 
While it does use the pid for the name, given the right conditions (like, oh, something that
spawns lots of child processes...), one could see a race there.

FWIW, the current code races pretty hard at the directory level in developer mode.  In Jenkins
mode, this should be less of a concern unless Jenkins isn't able to clean up it's workspace
directory.

> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch,
HADOOP-11746-03.patch, HADOOP-11746-04.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message