hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-11746) rewrite test-patch.sh
Date Fri, 27 Mar 2015 05:49:53 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Allen Wittenauer updated HADOOP-11746:
--------------------------------------
    Attachment: HADOOP-11746-02.patch

-02: 
* still very little new functionality, except that --dirty-workspace is now working for me.
* console output cleanup
* fix the /tmp default for the patch scratch space to be /tmp/(projname)-test-patch/pid to
allow for simultaneous test patch runs
* add in a timer to show how long various steps take (as requested by [~raviprak] )
* Fix more "we should have a var rather than hard code this binary" issues
* just skip the findbugs test if findbugs isn't installed
* send the mvn install run to a log file rather than dumping it to the screen
* fix some of the backslash indentation problems generated by the autoformatter


Current console output now looks like:

{code}
w$ dev-support/test-patch.sh --dirty-workspace /tmp/H1
Running in developer mode
/tmp/Hadoop-test-patch/54448 has been created


=======================================================================
=======================================================================
                        Testing patch for H1.
=======================================================================
=======================================================================
....
-1 overall

| Vote |           Subsystem | Comment
|  +1  |            @author  |  00m 00s  | The patch does not contain any 
                                         | @author tags.
|  -1  |     tests included  |  00m 00s  | The patch doesn't appear to include 
                                         | any new or modified tests. Please
                                         | justify why no new tests are needed
                                         | for this patch. Also please list what
                                         | manual steps were performed to verify
                                         | this patch.
|  +1  |              javac  |  04m 30s  | There were no new javac warning 
                                         | messages.
|  +1  |            javadoc  |  06m 15s  | There were no new javadoc warning 
                                         | messages.
|  +1  |    eclipse:eclipse  |  00m 24s  | The patch built with eclipse:eclipse.
|  -1  |      release audit  |  00m 05s  | The applied patch generated 1 release 
                                         | audit warnings.


=======================================================================
=======================================================================
                           Finished build.
=======================================================================
=======================================================================
{code}

Note the always centered text and the column wrap on the output. :D

> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message