hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-11746) rewrite test-patch.sh
Date Thu, 26 Mar 2015 04:32:53 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Allen Wittenauer updated HADOOP-11746:
--------------------------------------
    Attachment: HADOOP-11746-01.patch

-01:
* start preparing for set -euo pipefail mode (hopeful thinking)
* complain if JAVA_HOME isn't found since some of the maven tests fail if it isn't defined
*  JIRA output now uses more markup, because tables are cool
* rework the generic console output header bits to auto-center
* rework the error report based upon the new JIRA output, including splitting it out into
its own outputter 
* add a few helper routines to auto center text, etc.
* only find the changed modules once instead of twice
* run it through a shell code formatter, but I really hate how it handles backslashed lines
* lots of "oh we have a variable for this binary, but let's ignore it and call whatever is
in the path anyway" fixes
* fix a few inconsistencies in how we checked and reported errors
* updated quite a few things to modern bash semantics
* local and lowercase'd all of the local vars
* removed forrest bits

I haven't done a full run yet, never mind against Jenkins, but this one might actually work.
;) Still a lot to do, including making it pluggable and moving some of these bits into that
plug-in dir.

> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message