hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11746) rewrite test-patch.sh
Date Wed, 25 Mar 2015 05:00:53 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379301#comment-14379301
] 

Allen Wittenauer commented on HADOOP-11746:
-------------------------------------------

I'm going to go for bash for now, simply because there would be a ton of shell outs if we
did it in python to the point that half the code would be bash anyway.  I *might* write some
helper code in python to replace the wget though.  That would be significantly better to fetch
from JIRA via REST.

As it is, just running shellcheck on the existing code has found quite a few subtle bugs.
:(

> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message