hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11741) Add LOG.isDebugEnabled() guard for some LOG.debug()
Date Wed, 25 Mar 2015 15:44:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380083#comment-14380083
] 

Hudson commented on HADOOP-11741:
---------------------------------

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2093 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2093/])
HADOOP-11741. Add LOG.isDebugEnabled() guard for some LOG.debug(). Contributed by Walter Su.
(ozawa: rev 5582b0f1d469e7c98811a341c4b4c78eaa64ede5)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java


> Add LOG.isDebugEnabled() guard for some LOG.debug()
> ---------------------------------------------------
>
>                 Key: HADOOP-11741
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11741
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Walter Su
>            Assignee: Walter Su
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-11741.001.patch, HADOOP-11741.002.patch
>
>
> {{isDebugEnabled()}} is optional. But when there are :
> 1. lots of concatenating Strings
> 2. complicated function calls
> in the arguments, {{LOG.debug(..)}} should be guarded with {{LOG.isDebugEnabled()}} to
avoid unnecessary arguments evaluation and impove performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message