hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-11741) Add LOG.isDebugEnabled() guard for some LOG.debug()
Date Wed, 25 Mar 2015 07:37:53 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tsuyoshi Ozawa updated HADOOP-11741:
------------------------------------
          Resolution: Fixed
       Fix Version/s: 2.8.0
    Target Version/s: 2.8.0
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

Committed this to trunk and branch-2. Thanks [~walter.k.su] for your contribution!

> Add LOG.isDebugEnabled() guard for some LOG.debug()
> ---------------------------------------------------
>
>                 Key: HADOOP-11741
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11741
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Walter Su
>            Assignee: Walter Su
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-11741.001.patch, HADOOP-11741.002.patch
>
>
> {{isDebugEnabled()}} is optional. But when there are :
> 1. lots of concatenating Strings
> 2. complicated function calls
> in the arguments, {{LOG.debug(..)}} should be guarded with {{LOG.isDebugEnabled()}} to
avoid unnecessary arguments evaluation and impove performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message