hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11709) Time.NANOSECONDS_PER_MILLISECOND - use class-level final constant instead of method variable
Date Sat, 21 Mar 2015 15:13:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372833#comment-14372833
] 

Hudson commented on HADOOP-11709:
---------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #139 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/139/])
HADOOP-11709. Time.NANOSECONDS_PER_MILLISECOND - use class-level final constant instead of
method variable. Contributed by Ajith S. (ozawa: rev 43dde502b3be2133d62f1f074f016f35a56a7e2c)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Time.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> Time.NANOSECONDS_PER_MILLISECOND - use class-level final constant instead of method variable

> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11709
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11709
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ajith S
>            Assignee: Ajith S
>            Priority: Trivial
>              Labels: beginner, newbie
>             Fix For: 2.8.0
>
>         Attachments: 001-HDFS-7919.patch
>
>
> NANOSECONDS_PER_MILLISECOND constant can be moved to class level instead of creating
it in each method call.
> {code}
> org.apache.hadoop.util.Time.java
>  public static long monotonicNow() {
>     final long NANOSECONDS_PER_MILLISECOND = 1000000;
>     return System.nanoTime() / NANOSECONDS_PER_MILLISECOND;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message