hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11673) Use org.junit.Assume to skip tests instead of return
Date Sat, 07 Mar 2015 10:16:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351500#comment-14351500
] 

Hadoop QA commented on HADOOP-11673:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12703229/HADOOP-11673-001.patch
  against trunk revision 608ebd5.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5881//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5881//console

This message is automatically generated.

> Use org.junit.Assume to skip tests instead of return
> ----------------------------------------------------
>
>                 Key: HADOOP-11673
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11673
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>            Priority: Minor
>         Attachments: HADOOP-11673-001.patch, HADOOP-11673.patch
>
>
> We see the following code many times:
> {code:title=TestCodec.java}
>     if (!ZlibFactory.isNativeZlibLoaded(conf)) {
>       LOG.warn("skipped: native libs not loaded");
>       return;
>     }
> {code}
> If {{ZlibFactory.isNativeZlibLoaded(conf)}} is false, the test will *pass*, with a warn
log. I'd like to *skip* this test case by using {{org.junit.Assume}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message