hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kiran Kumar M R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
Date Tue, 03 Mar 2015 11:27:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344943#comment-14344943
] 

Kiran Kumar M R commented on HADOOP-11639:
------------------------------------------

[~rusanu], I applied your patch and verified both 32-bit and 64-bit builds. 
All warnings are resolved in 64-bit build.
Below warning is seen in 32-bit build
{code}
service.c(726): warning C4018: '<' : signed/unsigned mismatch [D:\hadoop-git\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
{code}

Changing code as below solves it
{code}
DWORD AuthInit() {
DWORD dwError = ERROR_SUCCESS;
size_t count = 0;
- int crt = 0;
+ unsigned int crt = 0;
size_t len = 0;
{code}

After the above change, there are no warnings in both builds.
You can consider adding above change in your patch.

> Clean up Windows native code compilation warnings related to Windows Secure Container
Executor.
> -----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11639
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11639
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.6.0
>            Reporter: Chris Nauroth
>            Assignee: Remus Rusanu
>         Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the NodeManager {{WindowsSecureContainerExecutor}}.
 The patch introduced new compilation warnings that we need to investigate and resolve.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message