hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11418) Property "io.compression.codec.lzo.class" does not work with other value besides default
Date Tue, 03 Mar 2015 09:23:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344798#comment-14344798
] 

Akira AJISAKA commented on HADOOP-11418:
----------------------------------------

Thanks [~fang fang chen] for the report and the patch. Nice catch. The fix looks good to me.
Two comments:
1. The code lookups {{conf}} twice. I'm thinking it's better to do in a single lookup as follows:
{code}
          String extClazz = conf.get(CONF_LZO_CLASS);
          if (extClazz == null) {
            extClazz = System.getProperty(CONF_LZO_CLASS);
          }
{code}
2. Would you add a regression test for this? I'm thinking the test will
* Set "io.compression.codec.lzo.class" to a codec other than the default lzo codec (ex. o.a.h.io.compress.DefaultCodec)
* Call {{Algorithm.LZO.isSupported()}}
* Call {{Algorithm.LZO.getCodec()}} and verify the specified codec is obtained.

> Property "io.compression.codec.lzo.class" does not work with other value besides default
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11418
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11418
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>            Reporter: fang fang chen
>            Assignee: fang fang chen
>         Attachments: HADOOP-11418.patch
>
>
> From following code, seems "io.compression.codec.lzo.class" does not work for other codec
besides default. Hadoop will always treat it as defaultClazz. I think it is a bug. Please
let me know if this is a work as design thing. Thanks
>      77       private static final String defaultClazz =
>      78           "org.apache.hadoop.io.compress.LzoCodec";
>      82       public synchronized boolean isSupported() {
>      83         if (!checked) {
>      84           checked = true;
>      85           String extClazz =
>      86               (conf.get(CONF_LZO_CLASS) == null ? System
>      87                   .getProperty(CONF_LZO_CLASS) : null);
>      88           String clazz = (extClazz != null) ? extClazz : defaultClazz;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message