hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Pierre Matsumoto (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-9805) Refactor RawLocalFileSystem#rename for improved testability.
Date Mon, 30 Mar 2015 22:08:54 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jean-Pierre Matsumoto updated HADOOP-9805:
------------------------------------------
    Attachment: HADOOP-9805.002.patch

Patch 002 attached.

Additional condition {{if (Shell.WINDOWS)}} added.

All the class is not thread-safe. I assume it’s better to keep it as is. And reliable way
to rename with Hadoop 2.7+ is to use {{NativeIO#renameTo(File, File)}} as noted by Steve’s
comment above.


> Refactor RawLocalFileSystem#rename for improved testability.
> ------------------------------------------------------------
>
>                 Key: HADOOP-9805
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9805
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, test
>    Affects Versions: 3.0.0, 1-win, 1.3.0, 2.1.1-beta
>            Reporter: Chris Nauroth
>            Assignee: Jean-Pierre Matsumoto
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-9805.001.patch, HADOOP-9805.002.patch
>
>
> {{RawLocalFileSystem#rename}} contains fallback logic to provide POSIX rename behavior
on platforms where {{java.io.File#renameTo}} fails.  The method returns early if {{java.io.File#renameTo}}
succeeds, so test runs may not cover the fallback logic depending on the platform.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message