hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
Date Sat, 14 Mar 2015 00:01:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361355#comment-14361355
] 

Colin Patrick McCabe commented on HADOOP-8887:
----------------------------------------------

I did try to work with cmake-maven-project in the past.  I wasn't able to get it working.
 The biggest issues were the lack of support for JDK6 (which would no longer be an issue,
of course), and the fact that it was mainly tested and developed on Windows.  I wasn't able
to get it to work on UNIX at all, after spending some time with it a few years ago.  It looks
like the project has not been very active (last commit was more than a year ago), so I don't
think there is a big benefit over just using cmake-maven-ng.  cmake-maven-ng also supported
a mode which allowed all tests to be run, or just a specific native test, something that a
large project like Hadoop really needs.  Now that we are bundling other maven plugins in the
Hadoop repo, we should probably just bundle the cmake-maven-ng plugin there.

> Use a Maven plugin to build the native code using CMake
> -------------------------------------------------------
>
>                 Key: HADOOP-8887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8887
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch,
HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch, HADOOP-8887.008.patch,
HADOOP-8887.011.patch
>
>
> Currently, we build the native code using ant-build invocations.  Although this works,
it has some limitations:
> * compiler warning messages are hidden, which can cause people to check in code with
warnings unintentionally
> * there is no framework for running native unit tests; instead, we use ad-hoc constructs
involving shell scripts
> * the antrun code is very platform specific
> * there is no way to run a specific native unit test
> * it's more or less impossible for scripts like test-patch.sh to separate a native test
failing from the build itself failing (no files are created) or to enumerate which native
tests failed.
> Using a native Maven plugin would overcome these limitations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message