Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2797C10138 for ; Mon, 16 Feb 2015 15:03:12 +0000 (UTC) Received: (qmail 65952 invoked by uid 500); 16 Feb 2015 15:03:11 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 65896 invoked by uid 500); 16 Feb 2015 15:03:11 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 65884 invoked by uid 99); 16 Feb 2015 15:03:11 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Feb 2015 15:03:11 +0000 Date: Mon, 16 Feb 2015 15:03:11 +0000 (UTC) From: "Tsuyoshi OZAWA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11603) Snapshot log can be removed #MetricsSystemImpl.java since all the services will intialzed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322834#comment-14322834 ] Tsuyoshi OZAWA commented on HADOOP-11603: ----------------------------------------- [~brahmareddy] the term "snapshot" is not related to HDFS snapshot in MetricsSystemImpl: {code} /** * Sample all the sources for a snapshot of metrics/tags * @return the metrics buffer containing the snapshot */ synchronized MetricsBuffer sampleMetrics() { {code} Is it OK to close this as "Not a problem"? > Snapshot log can be removed #MetricsSystemImpl.java since all the services will intialzed > ----------------------------------------------------------------------------------------- > > Key: HADOOP-11603 > URL: https://issues.apache.org/jira/browse/HADOOP-11603 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.6.0 > Reporter: Brahma Reddy Battula > Assignee: Brahma Reddy Battula > Priority: Minor > Attachments: HADOOP-11603.patch, defaultmetricIntialize-classes.JPG > > > Namenode,DataNode,journalnode,ResourceManager, Nodemanager and historyservice etc... will initialize DefaultMetricsSystem hence following log will be logged for all the classes which is not correct.. since snapshot feature is related to HDFS and this can be logged when snapshot is enabled. > {code} > LOG.info("Scheduled snapshot period at "+ period +" second(s)."); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)