Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A82F217407 for ; Tue, 3 Feb 2015 14:19:42 +0000 (UTC) Received: (qmail 26069 invoked by uid 500); 3 Feb 2015 14:19:43 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 26024 invoked by uid 500); 3 Feb 2015 14:19:43 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 26012 invoked by uid 99); 3 Feb 2015 14:19:43 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Feb 2015 14:19:43 +0000 Date: Tue, 3 Feb 2015 14:19:43 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11494) Lock acquisition on WrappedInputStream#unwrappedRpcBuffer may race with another thread MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303322#comment-14303322 ] Hudson commented on HADOOP-11494: --------------------------------- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #90 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/90/]) HADOOP-11494. Lock acquisition on WrappedInputStream#unwrappedRpcBuffer may race with another thread. Contributed by Ted Yu. (benoy: rev 3472e3bd6c50558870b86c9ccfea5072385fa991) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java > Lock acquisition on WrappedInputStream#unwrappedRpcBuffer may race with another thread > -------------------------------------------------------------------------------------- > > Key: HADOOP-11494 > URL: https://issues.apache.org/jira/browse/HADOOP-11494 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Minor > Fix For: 2.7.0 > > Attachments: hadoop-11494-001.patch, hadoop-11494-002.patch > > > In SaslRpcClient, starting at line 576: > {code} > public int read(byte[] buf, int off, int len) throws IOException { > synchronized(unwrappedRpcBuffer) { > // fill the buffer with the next RPC message > if (unwrappedRpcBuffer.remaining() == 0) { > readNextRpcPacket(); > } > {code} > readNextRpcPacket() may assign another ByteBuffer to unwrappedRpcBuffer, making the lock on previous ByteBuffer not useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332)