Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3D03617AB0 for ; Tue, 10 Feb 2015 22:35:13 +0000 (UTC) Received: (qmail 95665 invoked by uid 500); 10 Feb 2015 22:35:13 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 95614 invoked by uid 500); 10 Feb 2015 22:35:13 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 95601 invoked by uid 99); 10 Feb 2015 22:35:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 22:35:12 +0000 Date: Tue, 10 Feb 2015 22:35:12 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10953) NetworkTopology#add calls NetworkTopology#toString without holding the netlock MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315095#comment-14315095 ] Hudson commented on HADOOP-10953: --------------------------------- FAILURE: Integrated in Hadoop-trunk-Commit #7064 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7064/]) HADOOP-10953. NetworkTopology#add calls NetworkTopology#toString without holding the netlock (Liang Xie via Colin P. McCabe) (cmccabe: rev 6338ce3ae8870548cac5abe2f685748b5efb13c1) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java * hadoop-common-project/hadoop-common/CHANGES.txt > NetworkTopology#add calls NetworkTopology#toString without holding the netlock > ------------------------------------------------------------------------------ > > Key: HADOOP-10953 > URL: https://issues.apache.org/jira/browse/HADOOP-10953 > Project: Hadoop Common > Issue Type: Bug > Components: net > Affects Versions: 3.0.0 > Reporter: Liang Xie > Assignee: Liang Xie > Priority: Minor > Fix For: 2.7.0 > > Attachments: HADOOP-10953.txt > > > Found this issue while reading the related code. In NetworkTopology.toString() method, there is no thread safety guarantee directly, it's called by add/remove, and inside add/remove, most of this.toString() calls are protected by rwlock, except a couple of error handling codes, one possible fix is that moving them into lock as well, due to not heavy operations, so no obvious downgration should be observed per my current knowledge. -- This message was sent by Atlassian JIRA (v6.3.4#6332)