hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11626) DFSInputStream should only update ReadStatistics when the read is success.
Date Tue, 24 Feb 2015 23:28:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335654#comment-14335654
] 

Tsuyoshi OZAWA commented on HADOOP-11626:
-----------------------------------------

[~eddyxu] Thank you for reporting this issue. In this case, this is correct since reader.readAll
reads "nread" bytes from "buf" actually. Please correct me if I have a missing point.

> DFSInputStream should only update ReadStatistics when the read is success.
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-11626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11626
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Trivial
>         Attachments: HADOOP-11626.000.patch
>
>
> In {{DFSOutputStream#actualGetFromOneDataNode()}}, it updates the {{ReadStatistics}}
even the read is failed:
> {code}
>         int nread = reader.readAll(buf, offset, len);
>         updateReadStatistics(readStatistics, nread, reader);
>         if (nread != len) {
>           throw new IOException("truncated return from reader.read(): " +
>                                 "excpected " + len + ", got " + nread);
>         }
> {code}
> It should only record success read, i.e., after throwing {{IOE}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message