hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11599) Client#getTimeout should use IPC_CLIENT_PING_DEFAULT when IPC_CLIENT_PING_KEY is not configured.
Date Mon, 16 Feb 2015 07:36:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322468#comment-14322468
] 

Hadoop QA commented on HADOOP-11599:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12699037/HADOOP-11599.000.patch
  against trunk revision ab0b958.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5706//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5706//console

This message is automatically generated.

> Client#getTimeout should use IPC_CLIENT_PING_DEFAULT when IPC_CLIENT_PING_KEY is not
configured.
> ------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11599
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11599
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: HADOOP-11599.000.patch
>
>
> Client#getTimeout should use IPC_CLIENT_PING_DEFAULT instead of  hard-coded value (true)
when IPC_CLIENT_PING_KEY is not configured.
> {code}
>     if (!conf.getBoolean(CommonConfigurationKeys.IPC_CLIENT_PING_KEY, true)) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message