hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11584) s3a file block size set to 0 in getFileStatus
Date Fri, 13 Feb 2015 09:34:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319785#comment-14319785
] 

Hadoop QA commented on HADOOP-11584:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12698681/HADOOP-111584.patch
  against trunk revision ba3c80a.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-tools/hadoop-aws.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5684//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5684//console

This message is automatically generated.

> s3a file block size set to 0 in getFileStatus
> ---------------------------------------------
>
>                 Key: HADOOP-11584
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11584
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.6.0
>            Reporter: Dan Hecht
>            Assignee: Brahma Reddy Battula
>            Priority: Blocker
>         Attachments: HADOOP-111584.patch
>
>
> The consequence is that mapreduce probably is not splitting s3a files in the expected
way. This is similar to HADOOP-5861 (which was for s3n, though s3n was passing 5G rather than
0 for block size).
> FileInputFormat.getSplits() relies on the FileStatus block size being set:
> {code}
>         if (isSplitable(job, path)) {
>           long blockSize = file.getBlockSize();
>           long splitSize = computeSplitSize(blockSize, minSize, maxSize);
> {code}
> However, S3AFileSystem does not set the FileStatus block size field. From S3AFileStatus.java:
> {code}
>   // Files
>   public S3AFileStatus(long length, long modification_time, Path path) {
>     super(length, false, 1, 0, modification_time, path);
>     isEmptyDirectory = false;
>   }
> {code}
> I think it should use S3AFileSystem.getDefaultBlockSize() for each file's block size
(where it's currently passing 0).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message