hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11569) Provide Merge API for MapFile to merge multiple similar MapFiles to one MapFile
Date Thu, 26 Feb 2015 15:04:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338492#comment-14338492
] 

Tsuyoshi Ozawa commented on HADOOP-11569:
-----------------------------------------

Minor nits: it might be better to add test about values in testMerge like this:
{code}
        while (reader.next(key, value)) {
          assertTrue("Next key should be always equal or more",
              prev.get() <= key.get());
          assertEquals(
              new Text("Value:" + key.get()).toString(),
              value.toString());
          prev.set(key.get());
        }
{code}

Otherwise points looks good to me.

> Provide Merge API for MapFile to merge multiple similar MapFiles to one MapFile
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-11569
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11569
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HADOOP-11569-001.patch, HADOOP-11569-002.patch, HADOOP-11569-003.patch,
HADOOP-11569-004.patch, HADOOP-11569-005.patch
>
>
> If there are multiple similar MapFiles of the same keyClass and value classes, then these
can be merged together to One MapFile to allow search easier.
> Provide an API  similar to {{SequenceFile#merge()}}.
> Merging will be easy with the fact that MapFiles are already sorted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message