hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11512) Use getTrimmedStrings when reading serialization keys
Date Tue, 10 Feb 2015 10:42:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313976#comment-14313976
] 

Hudson commented on HADOOP-11512:
---------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #100 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/100/])
HADOOP-11512. Use getTrimmedStrings when reading serialization keys. Contributed by Ryan P.
(harsh: rev e0ec0718d033e84bda2ebeab7beb00b7dbd990c0)
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestSerializationFactory.java


> Use getTrimmedStrings when reading serialization keys
> -----------------------------------------------------
>
>                 Key: HADOOP-11512
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11512
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.6.0
>            Reporter: Harsh J
>            Assignee: Ryan P
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch, HADOOP-11512.patch,
HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch
>
>
> In the file {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) which does not trim
the input. This could cause confusing user issues if someone manually overrides the key in
the XML files/Configuration object without using the dynamic approach.
> The call should instead use Configuration#getTrimmedStrings(…), so the whitespace is
trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message