hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10953) NetworkTopology#add calls NetworkTopology#toString without holding the netlock
Date Tue, 10 Feb 2015 21:24:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314967#comment-14314967
] 

Colin Patrick McCabe commented on HADOOP-10953:
-----------------------------------------------

findbugs warnings are for {{org.apache.hadoop.fs.shell.Ls.processPath}} and {{org.apache.hadoop.fs.shell.Ls.dateFormat}},
neither of which were modified by this patch.

committing... thanks Liang Xie!

> NetworkTopology#add calls NetworkTopology#toString without holding the netlock
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-10953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10953
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: net
>    Affects Versions: 3.0.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>         Attachments: HADOOP-10953.txt
>
>
> Found this issue while reading the related code. In NetworkTopology.toString() method,
there is no thread safety guarantee directly, it's called by add/remove, and inside add/remove,
most of this.toString() calls are protected by rwlock, except a couple of error handling codes,
one possible fix is that moving them into lock as well, due to not heavy operations, so no
obvious downgration should be observed per my current knowledge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message