hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9844) NPE when trying to create an error message response of RPC
Date Mon, 23 Feb 2015 16:42:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333483#comment-14333483
] 

Jason Lowe commented on HADOOP-9844:
------------------------------------

bq. My patch as written in 2013 will catch it.

I don't believe it will because the patch only makes the toString change in getSaslReply.
 The stacktrace I posted earlier shows the error message is coming from getMessage in processOneRpc.

I'm all for changing the setupResponse callers to provide a non-null error message, but I
also believe it is prudent to have setupResponse better protect itself from null error messages.
 As the code evolves I suspect others may make the same kind of mistakes when calling setupResponse.

> NPE when trying to create an error message response of RPC
> ----------------------------------------------------------
>
>                 Key: HADOOP-9844
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9844
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.1.1-beta, 2.6.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-9844-001.patch
>
>
> I'm seeing an NPE which is raised when the server is trying to create an error response
to send back to the caller and there is no error text.
> The root cause is probably somewhere in SASL, but sending something back to the caller
would seem preferable to NPE-ing server-side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message