hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-6964) Allow compact property description in xml
Date Thu, 05 Feb 2015 22:17:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308102#comment-14308102
] 

Akira AJISAKA commented on HADOOP-6964:
---------------------------------------

bq. validate multiple definition of attributes and elements and abort with RuntimeException
I'm thinking it would be sufficient to output warning message as follows:
{code:title=Configuration.java}
          if ("name".equals(field.getTagName()) && field.hasChildNodes())
            if (attr != null) {
              LOG.warn("Detected multiple definitions. Property name: " + attr + 
                       " will be overwritten.");
            }
            attr = StringInterner.weakIntern(
                ((Text)field.getFirstChild()).getData().trim());
{code}
However, I'm okay with doing this by a separate jira. +1 for the patch, thanks Kengo and Allen.


> Allow compact property description in xml
> -----------------------------------------
>
>                 Key: HADOOP-6964
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6964
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Owen O'Malley
>            Assignee: Kengo Seki
>              Labels: newbie
>         Attachments: HADOOP-6964.patch
>
>
> We should allow users to use the more compact form of xml elements. For example, we could
allow:
> {noformat}
> <property name="mapred.local.dir" value="/disk/0/mapred,/disk/1/mapred"/>
> {noformat}
> The old format would also be supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message