Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F2C5917531 for ; Thu, 29 Jan 2015 21:57:35 +0000 (UTC) Received: (qmail 96314 invoked by uid 500); 29 Jan 2015 21:57:36 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 96269 invoked by uid 500); 29 Jan 2015 21:57:36 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 96255 invoked by uid 99); 29 Jan 2015 21:57:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2015 21:57:36 +0000 Date: Thu, 29 Jan 2015 21:57:36 +0000 (UTC) From: "Yongjun Zhang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11293) Factor OSType out from Shell MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297774#comment-14297774 ] Yongjun Zhang commented on HADOOP-11293: ---------------------------------------- Hi [~cnauroth] and [~stevel@apache.org], About the test results: Rerunning the tests locally, TestBlockScanner and TestHttpCookieFlag are successful. TestJobConf failure was reported as MAPREDUCE-6223. TestLargeSort failed in trunk test, I created MAPREDUCE-6233 about it. The findbugs are not related to my changes, so I think it should not block this jira. but I will take a look at them later. Thanks. > Factor OSType out from Shell > ---------------------------- > > Key: HADOOP-11293 > URL: https://issues.apache.org/jira/browse/HADOOP-11293 > Project: Hadoop Common > Issue Type: Improvement > Components: fs, util > Reporter: Yongjun Zhang > Assignee: Yongjun Zhang > Attachments: HADOOP-11293.001.patch, HADOOP-11293.002.patch, HADOOP-11293.003.patch, HADOOP-11293.004.patch, HADOOP-11293.005.patch > > > Currently the code that detects the OS type is located in Shell.java. Code that need to check OS type refers to Shell, even if no other stuff of Shell is needed. > I am proposing to refactor OSType out to its own class, so to make the OSType easier to access and the dependency cleaner. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)