Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 2 Jan 2015 18:22:35 +0000 (UTC)
From: "Zhijie Shen (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12750421.1414176207000.140.1420222955167@Atlassian.JIRA>
In-Reply-To: <JIRA.12750421.1414176207000@Atlassian.JIRA>
References: <JIRA.12750421.1414176207000@Atlassian.JIRA>
 <JIRA.12750421.1414176207537@arcas>
Subject: [jira] [Commented] (HADOOP-11229) JobStoryProducer is not closed
 upon return from Gridmix#setupDistCacheEmulation()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263104#comment-14263104 ] 

Zhijie Shen commented on HADOOP-11229:
--------------------------------------

[~skrho], thanks for the contribution. One suggestion: you can use o.a.h.i.IOUtils.cleanup. And you don't need to check if jsp is null or not.

> JobStoryProducer is not closed upon return from Gridmix#setupDistCacheEmulation()
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-11229
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11229
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: skrho
>            Priority: Minor
>         Attachments: HADOOP-11229_001.patch, HADOOP-11229_002.patch
>
>
> Here is related code:
> {code}
>       JobStoryProducer jsp = createJobStoryProducer(traceIn, conf);
>       exitCode = distCacheEmulator.setupGenerateDistCacheData(jsp);
> {code}
> jsp should be closed upon return from setupDistCacheEmulation().


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)