hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11499) Check of executorThreadsStarted in ValueQueue#submitRefillTask() evades lock acquisition
Date Thu, 22 Jan 2015 17:45:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287843#comment-14287843
] 

Ted Yu commented on HADOOP-11499:
---------------------------------

@Jason:
What do you think of the patch ?

> Check of executorThreadsStarted in ValueQueue#submitRefillTask() evades lock acquisition
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11499
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11499
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: hadoop-11499-001.patch
>
>
> {code}
>     if (!executorThreadsStarted) {
>       synchronized (this) {
>         // To ensure all requests are first queued, make coreThreads =
>         // maxThreads
>         // and pre-start all the Core Threads.
>         executor.prestartAllCoreThreads();
>         executorThreadsStarted = true;
>       }
>     }
> {code}
> It is possible that two threads executing the above code both see executorThreadsStarted
as being false, leading to executor.prestartAllCoreThreads() called twice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message