hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11494) Lock acquisition on WrappedInputStream#unwrappedRpcBuffer may race with another thread
Date Thu, 29 Jan 2015 15:55:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297046#comment-14297046
] 

Hadoop QA commented on HADOOP-11494:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12695285/hadoop-11494-002.patch
  against trunk revision 03a5e04.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5534//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5534//console

This message is automatically generated.

> Lock acquisition on WrappedInputStream#unwrappedRpcBuffer may race with another thread
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11494
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11494
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: hadoop-11494-001.patch, hadoop-11494-002.patch
>
>
> In SaslRpcClient, starting at line 576:
> {code}
>     public int read(byte[] buf, int off, int len) throws IOException {
>       synchronized(unwrappedRpcBuffer) {
>         // fill the buffer with the next RPC message
>         if (unwrappedRpcBuffer.remaining() == 0) {
>           readNextRpcPacket();
>         }
> {code}
> readNextRpcPacket() may assign another ByteBuffer to unwrappedRpcBuffer, making the lock
on previous ByteBuffer not useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message