hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11475) Utilize try-with-resource to close StopWatch
Date Mon, 19 Jan 2015 02:34:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282095#comment-14282095
] 

Hadoop QA commented on HADOOP-11475:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12692050/hadoop-11475-001.patch
  against trunk revision 24315e7.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5424//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5424//console

This message is automatically generated.

> Utilize try-with-resource to close StopWatch
> --------------------------------------------
>
>                 Key: HADOOP-11475
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11475
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: hadoop-11475-001.patch
>
>
> Currently the stop() method of StopWatch is called without using finally clause.
> This can result in resource leak if there is IOE thrown.
> Here is one example from Journal#journal():
> {code}
>     StopWatch sw = new StopWatch();
>     sw.start();
>     curSegment.flush(shouldFsync);
>     sw.stop();
> {code}
> If curSegment.flush() throws IOE, sw would be left unclosed.
> Propose using try-with-resource structure to close the StopWatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message