hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11465) Findbugs in hadoop-gridmix
Date Mon, 12 Jan 2015 22:19:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274282#comment-14274282
] 

Arpit Agarwal commented on HADOOP-11465:
----------------------------------------

Thanks for the fixes [~varun_saxena].

{code}
        bytes -= (randomValue.getBytes(Charset.forName("UTF-8")).length +
            randomKey.getBytes(Charset.forName("UTF-8")).length);
{code}
{{Charset.forName}} is an expensive call. We can call it once in a static context and cache
the resulting {{Charset}}. Same for the other classes.

+1 with that fixed.

> Findbugs in hadoop-gridmix
> --------------------------
>
>                 Key: HADOOP-11465
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11465
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: HADOOP-11465.001.patch, newPatchFindbugsWarningshadoop-gridmix.html
>
>
> Fix findbugs issues in hadoop-gridmix



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message