hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11460) Deprecrate shell vars
Date Fri, 16 Jan 2015 21:08:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280825#comment-14280825
] 

Hadoop QA commented on HADOOP-11460:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12692800/HADOOP-11460-01.patch
  against trunk revision 000ca83.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.ha.TestZKFailoverControllerStress
                  org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5418//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5418//console

This message is automatically generated.

> Deprecrate shell vars
> ---------------------
>
>                 Key: HADOOP-11460
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11460
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: scripts
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>              Labels: scripts, shell
>         Attachments: HADOOP-11460-00.patch, HADOOP-11460-01.patch
>
>
> It is a very common shell pattern in 3.x to effectively replace sub-project specific
vars with generics.  We should have a function that does this replacement and provides a warning
to the end user that the old shell var is deprecated.  Additionally, we should use this shell
function to deprecate the shell vars that are holdovers already.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message