hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11455) KMS and Credential CLI should request confirmation for deletion by default
Date Sun, 04 Jan 2015 04:06:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263750#comment-14263750
] 

Yi Liu commented on HADOOP-11455:
---------------------------------

I agree that it's good get confirmation for deletion by default.
The patch looks good to me, just 1 small nit, +1 after addressing.
*1.* we have following change in KeyShell.java
{code}
-                  + " key: " + keyName + " from KeyProvider "
-                  + provider + ". Continue?:");
+                  + " key " + keyName + " from KeyProvider "
+                  + provider + ". Continue? ");
{code}
Could we make it consistent in CredentialShell.java?




> KMS and Credential CLI should request confirmation for deletion by default
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-11455
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11455
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.7.0
>            Reporter: Charles Lamb
>            Assignee: Charles Lamb
>            Priority: Minor
>         Attachments: HADOOP-11455.000.patch
>
>
> The hadoop key delete and hadoop credential delete currently only ask for confirmation
of the delete if -i is specified. Asking for confirmation should be the default action for
both.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message