hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
Date Thu, 08 Jan 2015 02:10:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268708#comment-14268708
] 

Hadoop QA commented on HADOOP-11393:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12690607/HADOOP-11393-00.patch
  against trunk revision 3ed0aed.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 15 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common
hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-datajoin
hadoop-tools/hadoop-streaming hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5377//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5377//artifact/patchprocess/newPatchFindbugsWarningshadoop-datajoin.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5377//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5377//console

This message is automatically generated.

> Revert HADOOP_PREFIX, go back to HADOOP_HOME
> --------------------------------------------
>
>                 Key: HADOOP-11393
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11393
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>         Attachments: HADOOP-11393-00.patch
>
>
> Today, Windows and parts of the Hadoop source code still use HADOOP_HOME.  The switch
to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what it was intended to do and
only helped confuse the situation.
> _HOME is a much more standard suffix and is, in fact, used for everything in Hadoop except
for the top level project home.  I think it would be beneficial to use HADOOP_HOME in the
shell code as the Official(tm) variable, still honoring HADOOP_PREFIX if it is set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message