hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8757) Metrics should disallow names with invalid characters
Date Fri, 16 Jan 2015 15:42:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280418#comment-14280418
] 

Hudson commented on HADOOP-8757:
--------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2026 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2026/])
HADOOP-8757. Metrics should disallow names with invalid characters (rchiang via rkanter) (rkanter:
rev b6ff9c03a4f8aba945e562a7ff60b0fc6a1cd040)
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java


> Metrics should disallow names with invalid characters
> -----------------------------------------------------
>
>                 Key: HADOOP-8757
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8757
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Todd Lipcon
>            Assignee: Ray Chiang
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.7.0
>
>         Attachments: HADOOP-8757-01.patch, HADOOP-8757-02.patch, HADOOP-8757.003.patch
>
>
> Just spent a couple hours trying to figure out why a metric I added didn't show up in
JMX, only to eventually realize it was because I had a whitespace in the property name. This
didn't cause any errors to be logged -- the metric just didn't show up in JMX. We should check
that the name is valid and log an error, or replace invalid characters with something like
an underscore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message