Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70109104A1 for ; Tue, 30 Dec 2014 17:54:13 +0000 (UTC) Received: (qmail 74216 invoked by uid 500); 30 Dec 2014 17:54:13 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 74168 invoked by uid 500); 30 Dec 2014 17:54:13 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 74156 invoked by uid 99); 30 Dec 2014 17:54:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Dec 2014 17:54:13 +0000 Date: Tue, 30 Dec 2014 17:54:13 +0000 (UTC) From: "Steve Loughran (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11447) Add a more meaningful toString method to SampleStat and MutableStat MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261302#comment-14261302 ] Steve Loughran commented on HADOOP-11447: ----------------------------------------- Are you confident that things like variance & stddev are never going to raise errors -or should that string construction be caught & downgraded to a super.toString()? There's nothing worse than logging triggering strack traces > Add a more meaningful toString method to SampleStat and MutableStat > ------------------------------------------------------------------- > > Key: HADOOP-11447 > URL: https://issues.apache.org/jira/browse/HADOOP-11447 > Project: Hadoop Common > Issue Type: Improvement > Components: metrics > Affects Versions: 2.6.0 > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Priority: Minor > Attachments: hadoop-11447-1.patch > > > SampleStat and MutableStat don't override the toString method. A more meaningful implementation could help with debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)