Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D75C7C04C for ; Tue, 16 Dec 2014 01:11:50 +0000 (UTC) Received: (qmail 31643 invoked by uid 500); 16 Dec 2014 01:11:48 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 31584 invoked by uid 500); 16 Dec 2014 01:11:48 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 31504 invoked by uid 99); 16 Dec 2014 01:11:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Dec 2014 01:11:48 +0000 Date: Tue, 16 Dec 2014 01:11:48 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11410) make the rpath of libhadoop.so configurable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247546#comment-14247546 ] Colin Patrick McCabe commented on HADOOP-11410: ----------------------------------------------- bq. Patch looks pretty good to me, Colin. Can you perhaps comment on what testing you've done of this change? It seems quite straightforward to me, but it'd be good if you could let us know what verification of this you've done. I built with and without {{\-Dextra.libhadoop.rpath=/tmp/foo}} and verified that the RPATH was as expected using {{chrpath -l}} One small suggestion on the actual contents of the patch: given that we're now adding $ORIGIN into the RPATH before the SET_TARGET_PROPERTIES call, seems like it'd be better to move the associated comment explaining the purpose of that up as well. yeah > make the rpath of libhadoop.so configurable > -------------------------------------------- > > Key: HADOOP-11410 > URL: https://issues.apache.org/jira/browse/HADOOP-11410 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 2.7.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HADOOP-11410.001.patch > > > We should make the rpath of {{libhadoop.so}} configurable, so that we can use a different rpath if needed. The {{RPATH}} of {{libhadoop.so}} is primarily used to control where {{dlopen}} looks for shared libraries by default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)