Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1181B1064F for ; Mon, 15 Dec 2014 22:00:16 +0000 (UTC) Received: (qmail 78195 invoked by uid 500); 15 Dec 2014 22:00:15 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 78155 invoked by uid 500); 15 Dec 2014 22:00:15 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 78096 invoked by uid 99); 15 Dec 2014 22:00:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Dec 2014 22:00:15 +0000 Date: Mon, 15 Dec 2014 22:00:15 +0000 (UTC) From: "Li Lu (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-11387) Simplify NetUtils#canonicalizeHost() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Li Lu updated HADOOP-11387: --------------------------- Attachment: HADOOP-11387-121514.patch In this patch I used LoadingCache to replace ConcurrentHashMap. After this change the logic of canonicalizedHostCache is simplified. > Simplify NetUtils#canonicalizeHost() > ------------------------------------ > > Key: HADOOP-11387 > URL: https://issues.apache.org/jira/browse/HADOOP-11387 > Project: Hadoop Common > Issue Type: Bug > Reporter: Haohui Mai > Assignee: Li Lu > Attachments: HADOOP-11387-121514.patch > > > Currently {{NetUtils#canonicalizeHost}} uses a {{ConcurrentHashMap}} to cache the canonicalized hostname. > {code} > private static String canonicalizeHost(String host) { > // check if the host has already been canonicalized > String fqHost = canonicalizedHostCache.get(host); > if (fqHost == null) { > try { > fqHost = SecurityUtil.getByName(host).getHostName(); > // slight race condition, but won't hurt > canonicalizedHostCache.put(host, fqHost); > } catch (UnknownHostException e) { > fqHost = host; > } > } > return fqHost; > } > {code} > The code can be simplified using {{CacheMap}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)