Return-Path: 
 <common-issues-return-73577-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D0E4295C8
	for <apmail-hadoop-common-issues-archive@minotaur.apache.org>;
 Tue,  9 Dec 2014 09:30:12 +0000 (UTC)
Received: (qmail 27592 invoked by uid 500); 9 Dec 2014 09:30:12 -0000
Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org
Received: (qmail 27549 invoked by uid 500); 9 Dec 2014 09:30:12 -0000
Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:common-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:common-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:common-issues@hadoop.apache.org>
List-Id: <common-issues.hadoop.apache.org>
Reply-To: common-issues@hadoop.apache.org
Delivered-To: mailing list common-issues@hadoop.apache.org
Received: (qmail 27537 invoked by uid 99); 9 Dec 2014 09:30:12 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Dec 2014 09:30:12 +0000
Date: Tue, 9 Dec 2014 09:30:12 +0000 (UTC)
From: "Li Lu (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12760396.1418116774000.108055.1418117412384@Atlassian.JIRA>
In-Reply-To: <JIRA.12760396.1418116774000@Atlassian.JIRA>
References: <JIRA.12760396.1418116774000@Atlassian.JIRA>
 <JIRA.12760396.1418116774807@arcas>
Subject: [jira] [Updated] (HADOOP-11372) Fix new findbugs warnings in
 mapreduce-examples
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HADOOP-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Lu updated HADOOP-11372:
---------------------------
    Attachment: HADOOP-11372-120914.patch

In this patch I fixed the only two warnings raised by findbugs 3.0 against mapreduce-examples. I fixed a unnecessary null check on final List<T> results = Util.combine(m.get(p)); where Util.combine will never return null (looks like a false alarm but actually is not). I also added throws NoSuchElementException to Sum's iterator per findbugs's suggestion. 

> Fix new findbugs warnings in mapreduce-examples
> -----------------------------------------------
>
>                 Key: HADOOP-11372
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11372
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: HADOOP-11372-120914.patch
>
>
> When locally run findbugs 3.0, there are new warnings generated. This Jira aims to address the new warnings in mapreduce-examples. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)