Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED499101BC for ; Thu, 18 Dec 2014 14:59:17 +0000 (UTC) Received: (qmail 71869 invoked by uid 500); 18 Dec 2014 14:59:15 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 71822 invoked by uid 500); 18 Dec 2014 14:59:15 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 71783 invoked by uid 99); 18 Dec 2014 14:59:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Dec 2014 14:59:15 +0000 Date: Thu, 18 Dec 2014 14:59:15 +0000 (UTC) From: "Steve Loughran (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11032) Replace use of Guava Stopwatch with Apache StopWatch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251748#comment-14251748 ] Steve Loughran commented on HADOOP-11032: ----------------------------------------- ..nanoTime is less brittle to clock drift/regression on VMs. with our own class we could also go for a 1:1 mapping on Guava, e.g. make close() idempotent. In fact, make it Closeable for the new try/catch stuff. I'd recommend making the now() operation overiddeable in subclasses for ease of testing; the test class would increment by 1 each call or similar It's a shame to have to reimplement stuff, but sometimes its easier that way. > Replace use of Guava Stopwatch with Apache StopWatch > ---------------------------------------------------- > > Key: HADOOP-11032 > URL: https://issues.apache.org/jira/browse/HADOOP-11032 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Gary Steelman > Assignee: Tsuyoshi OZAWA > Attachments: HADOOP-11032.1.patch, HADOOP-11032.2.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch > > > This patch reduces Hadoop's dependency on an old version of guava. Stopwatch.elapsedMillis() isn't part of guava past v16 and the tools I'm working on use v17. > To remedy this and also reduce Hadoop's reliance on old versions of guava, we can use the Apache StopWatch (org.apache.commons.lang.time.StopWatch) which provides nearly equivalent functionality. apache.commons.lang is already a dependency for Hadoop so this will not introduce new dependencies. -- This message was sent by Atlassian JIRA (v6.3.4#6332)