hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11434) Correct the comment of ByteBufferReadable#read
Date Fri, 19 Dec 2014 10:17:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253212#comment-14253212
] 

Hadoop QA commented on HADOOP-11434:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12688281/HADOOP-11434.001.patch
  against trunk revision 6635ccd.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation patch
that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5312//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5312//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5312//console

This message is automatically generated.

> Correct the comment of ByteBufferReadable#read
> ----------------------------------------------
>
>                 Key: HADOOP-11434
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11434
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>            Priority: Minor
>         Attachments: HADOOP-11434.001.patch
>
>
> The following comment of {{ByteBufferReadable#read}} seems not correct, actually, the
position of {{buf}} should be updated:
> {code}
> After a successful call, buf.position() and buf.limit() should be
> -   * unchanged, and therefore any data can be immediately read from buf.
> -   * buf.mark() may be cleared or updated.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message