hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11430) Add GenericTestUtils#disableLog, GenericTestUtils#setLogLevel
Date Thu, 18 Dec 2014 22:51:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252462#comment-14252462

Andrew Wang commented on HADOOP-11430:

Cool patch, +1 pending Jenkins

> Add GenericTestUtils#disableLog, GenericTestUtils#setLogLevel
> -------------------------------------------------------------
>                 Key: HADOOP-11430
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11430
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HADOOP-11430.001.patch
> Now that we are using both commons-logging and slf4j, we can no longer rely on just casting
the Log object to a {{Log4JLogger}} and calling {{setLevel}} on that.  With {{org.slf4j.Logger}}
objects, we need to look up the underlying {{Log4JLogger}} using {{LogManager#getLogger}}.
> This patch adds {{GenericTestUtils#disableLog}} and {{GenericTestUtils#setLogLevel}}
functions which hide this complexity from unit tests, just allowing the tests to call {{disableLog}}
or {{setLogLevel}}, and have {{GenericTestUtils}} figure out the right thing to do based on
the log / logger type.

This message was sent by Atlassian JIRA

View raw message