hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-11387) Simplify NetUtils#canonicalizeHost()
Date Mon, 15 Dec 2014 22:00:15 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Li Lu updated HADOOP-11387:
---------------------------
    Attachment: HADOOP-11387-121514.patch

In this patch I used LoadingCache to replace ConcurrentHashMap. After this change the logic
of canonicalizedHostCache is simplified. 

> Simplify NetUtils#canonicalizeHost()
> ------------------------------------
>
>                 Key: HADOOP-11387
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11387
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Li Lu
>         Attachments: HADOOP-11387-121514.patch
>
>
> Currently {{NetUtils#canonicalizeHost}} uses a {{ConcurrentHashMap}} to cache the canonicalized
hostname.
> {code}
>   private static String canonicalizeHost(String host) {
>     // check if the host has already been canonicalized
>     String fqHost = canonicalizedHostCache.get(host);
>     if (fqHost == null) {
>       try {
>         fqHost = SecurityUtil.getByName(host).getHostName();
>         // slight race condition, but won't hurt
>         canonicalizedHostCache.put(host, fqHost);
>       } catch (UnknownHostException e) {
>         fqHost = host;
>       }
>     }
>     return fqHost;
>   }
> {code}
> The code can be simplified using {{CacheMap}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message