hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11301) [optionally] update jmx cache to drop old metrics
Date Tue, 02 Dec 2014 14:07:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231516#comment-14231516
] 

Hudson commented on HADOOP-11301:
---------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #23 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/23/])
HADOOP-11301. [optionally] update jmx cache to drop old metrics  (Maysam Yabandeh via stack)
-- REAPPLY #2 (stack: rev b36f29298247f6c5db9f6eff7c2f5177a0fe3de5)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> [optionally] update jmx cache to drop old metrics
> -------------------------------------------------
>
>                 Key: HADOOP-11301
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11301
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Maysam Yabandeh
>            Assignee: Maysam Yabandeh
>             Fix For: 2.7.0
>
>         Attachments: HADOOP-11301.v01.patch, HADOOP-11301.v02.patch, HADOOP-11301.v03.patch,
HADOOP-11301.v04.patch
>
>
> MetricsSourceAdapter::updateJmxCache() skips updating the info cache if no new metric
is added since last time:
> {code}
>       int oldCacheSize = attrCache.size();
>       int newCacheSize = updateAttrCache();
>       if (oldCacheSize < newCacheSize) {
>         updateInfoCache();
>       }
> {code}
> This behavior is not desirable in some applications. For example nntop (HDFS-6982) reports
the top users via jmx. The list is updated after each report. The previously reported top
users hence should be removed from the cache upon each report request.
> In our production run of nntop we made a change to ignore the size check and always perform
updateInfoCache. I am planning to submit a patch including this change. The feature can be
enabled by a configuration parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message