hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11283) Potentially unclosed SequenceFile.Writer in DistCpV1#setup()
Date Fri, 26 Dec 2014 14:32:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259086#comment-14259086
] 

Hudson commented on HADOOP-11283:
---------------------------------

SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #50 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/50/])
HADOOP-11283. SequenceFile.Writer can leak file descriptors in DistCpV1#setup(). (Contributed
by Varun Saxena via ozawa) (ozawa: rev a164ce2ac985ecac957362fc717640ad45449371)
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCpV1.java


> Potentially unclosed SequenceFile.Writer in DistCpV1#setup()
> ------------------------------------------------------------
>
>                 Key: HADOOP-11283
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11283
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Ted Yu
>            Assignee: Varun Saxena
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: HADOOP-11283.001.patch, HADOOP-11283.002.patch, HADOOP-11283.patch
>
>
> {code}
>     SequenceFile.Writer src_writer = SequenceFile.createWriter(jobfs, jobConf,
>         srcfilelist, LongWritable.class, FilePair.class,
>         SequenceFile.CompressionType.NONE);
>     Path dstfilelist = new Path(jobDirectory, "_distcp_dst_files");
>     SequenceFile.Writer dst_writer = SequenceFile.createWriter(jobfs, jobConf,
>         dstfilelist, Text.class, Text.class,
>         SequenceFile.CompressionType.NONE);
> {code}
> If creation of dst_writer throws exception, src_writer would be left unclosed since there
is no finally clause doing that for the above code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message