hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11032) Replace use of Guava Stopwatch with Apache StopWatch
Date Thu, 18 Dec 2014 14:59:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251748#comment-14251748
] 

Steve Loughran commented on HADOOP-11032:
-----------------------------------------

..nanoTime is less brittle to clock drift/regression on VMs. 

with our own class we could also go for a 1:1 mapping on Guava, e.g. make close() idempotent.
In fact, make it Closeable for the new try/catch stuff.

I'd recommend making the now() operation overiddeable in subclasses for ease of testing; the
test class would increment by 1 each call or similar
It's a shame to have to reimplement stuff, but sometimes its easier that way. 

> Replace use of Guava Stopwatch with Apache StopWatch
> ----------------------------------------------------
>
>                 Key: HADOOP-11032
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11032
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Gary Steelman
>            Assignee: Tsuyoshi OZAWA
>         Attachments: HADOOP-11032.1.patch, HADOOP-11032.2.patch, HADOOP-11032.3.patch,
HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch
>
>
> This patch reduces Hadoop's dependency on an old version of guava. Stopwatch.elapsedMillis()
isn't part of guava past v16 and the tools I'm working on use v17. 
> To remedy this and also reduce Hadoop's reliance on old versions of guava, we can use
the Apache StopWatch (org.apache.commons.lang.time.StopWatch) which provides nearly equivalent
functionality. apache.commons.lang is already a dependency for Hadoop so this will not introduce
new dependencies. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message