Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 13 Nov 2014 23:44:35 +0000 (UTC)
From: "Yongjun Zhang (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12754244.1415651716000.495500.1415922275139@Atlassian.JIRA>
In-Reply-To: <JIRA.12754244.1415651716000@Atlassian.JIRA>
References: <JIRA.12754244.1415651716000@Atlassian.JIRA>
 <JIRA.12754244.1415651716556@arcas>
Subject: [jira] [Commented] (HADOOP-11293) Factor OSType out from Shell
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14211491#comment-14211491 ] 

Yongjun Zhang commented on HADOOP-11293:
----------------------------------------

Cool Steve, thanks for your feedback and sharing another way of doing it. I'm taking it as an OK from you to use the new name:-) 

I will work on a new rev that takes care of the extra empty lines soon.

Thanks.


> Factor OSType out from Shell
> ----------------------------
>
>                 Key: HADOOP-11293
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11293
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-11293.001.patch, HADOOP-11293.002.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code that need to check OS type refers to Shell, even if no other stuff of Shell is needed. 
> I am proposing to refactor OSType out to  its own class, so to make the OSType easier to access and the dependency cleaner.
>  


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)