Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C895D104ED for ; Tue, 4 Nov 2014 14:21:35 +0000 (UTC) Received: (qmail 77394 invoked by uid 500); 4 Nov 2014 14:21:35 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 77350 invoked by uid 500); 4 Nov 2014 14:21:35 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 77337 invoked by uid 99); 4 Nov 2014 14:21:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Nov 2014 14:21:35 +0000 Date: Tue, 4 Nov 2014 14:21:35 +0000 (UTC) From: "jay vyas (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11244) The HCFS contract test testRenameFileBeingAppended doesn't do a rename MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196139#comment-14196139 ] jay vyas commented on HADOOP-11244: ----------------------------------- hi [~stevel@apache.org] id propose - first, we remove this test from the code. - then, fix HADOOP-11251, make all the tests run. -in the meanwhile, we can leisurely decide how to test testRenameFileBeingAppended test . Right now, given the complexity of the issue and time constraints, *i think its best to remove dead code so HCFS tests work perfectly again*. let me know thoughts on this (or maybe another plan forward if you have one)? > The HCFS contract test testRenameFileBeingAppended doesn't do a rename > ---------------------------------------------------------------------- > > Key: HADOOP-11244 > URL: https://issues.apache.org/jira/browse/HADOOP-11244 > Project: Hadoop Common > Issue Type: Bug > Components: test > Reporter: Noah Watkins > Assignee: jay vyas > Fix For: 2.6.0 > > Attachments: HADOOP-11244.patch, HADOOP-11244.patch > > > The test AbstractContractAppendTest::testRenameFileBeingAppended appears to assert the behavior of renaming a file opened for writing. However, the assertion "assertPathExists("renamed destination file does not exist", renamed);" fails because it appears that the file "renamed" is never created (ostensibly it should be the "target" file that has been renamed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)