Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 12 Nov 2014 02:43:34 +0000 (UTC)
From: "Akira AJISAKA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12697073.1393306952000.476097.1415760214720@Atlassian.JIRA>
In-Reply-To: <JIRA.12697073.1393306952000@Atlassian.JIRA>
References: <JIRA.12697073.1393306952000@Atlassian.JIRA>
 <JIRA.12697073.1393306952929@arcas>
Subject: [jira] [Commented] (HADOOP-10365) BufferedOutputStream in
 FileUtil#unpackEntries() should be closed in finally block
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207585#comment-14207585 ] 

Akira AJISAKA commented on HADOOP-10365:
----------------------------------------

bq. So, need to cleanup.
Agree. The patch looks mostly good. Minor nits:
1.
{code}
+    } catch (IOException e) {
+      throw e;
{code}
These lines are no-op, so they can be removed.
2. 
{code}
+      outputStream = new BufferedOutputStream(new FileOutputStream(outputFile))
{code}
Would you please render the line within 80 characters?

> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-10365
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10365
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10365.2.patch, HADOOP-10365.patch
>
>
> {code}
>     BufferedOutputStream outputStream = new BufferedOutputStream(
>         new FileOutputStream(outputFile));
> ...
>     outputStream.flush();
>     outputStream.close();
> {code}
> outputStream should be closed in finally block.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)