hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhihai xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11323) WritableComparator: default implementation of compare keeps reference to byte array
Date Thu, 20 Nov 2014 11:01:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219248#comment-14219248
] 

zhihai xu commented on HADOOP-11323:
------------------------------------

LGTM

> WritableComparator: default implementation of compare keeps reference to byte array
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-11323
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11323
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: performance
>    Affects Versions: 2.5.0
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>         Attachments: HADOOP-11323.patch
>
>
> When the default compare is used on a WritableComparator a reference to the second passed
in byte array is kept in the buffer. Since WritableComparator keeps a reference to the buffer
the byte will never be garbage collected. This can lead to a higher heap use than needed.
> The buffer should drop the reference to the byte array passed in. We can null out the
byte array reference since the buffer is a private variable for the class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message