hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11293) Factor OSType out from Shell
Date Tue, 11 Nov 2014 19:56:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206945#comment-14206945
] 

Colin Patrick McCabe commented on HADOOP-11293:
-----------------------------------------------

I think these are valid points and perhaps we should rethink this change.

It's frustrating that in this case, the {{\@InterfaceAudience}} tags seem to have been completely
ignored, and the {{Shell.java}} APIs are now effectively public.  Is there anything we can
do to keep this from happening again in the future?

> Factor OSType out from Shell
> ----------------------------
>
>                 Key: HADOOP-11293
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11293
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-11293.001.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code that need
to check OS type refers to Shell, even if no other stuff of Shell is needed. 
> I am proposing to refactor OSType out to  its own class, so to make the OSType easier
to access and the dependency cleaner.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message