hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11157) ZKDelegationTokenSecretManager never shuts down listenerThreadPool
Date Thu, 13 Nov 2014 04:36:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209257#comment-14209257
] 

Aaron T. Myers commented on HADOOP-11157:
-----------------------------------------

Latest patch looks pretty good to me. A few comments:

# Looks like we still have an inadvertent extra "+" here: "+        +        ZK_DTSM_ZK_SHUTDOWN_TIMEOUT_DEFAULT);"
# In {{stopThreads(...)}}, do we really need to nest all of those try/finally blocks? Given
that content of most of the "{{catch}}" blocks is just to log and ignore, seems like they
don't need to be nested, and instead we can do away with the finally blocks and just list
the {{try/catch}} blocks linearly.
# In the case that shutting down the thread pool times out, recommend logging an error before
forcefully shutting down the thread pool.
# Given that the new tests time out when run on our Jenkins infrastructure, seems like we
should lower the default number of {{TEST_RETRIES}} to 1 or 2.

I'll be +1 once the above are addressed and Jenkins comes back clean.

> ZKDelegationTokenSecretManager never shuts down listenerThreadPool
> ------------------------------------------------------------------
>
>                 Key: HADOOP-11157
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11157
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Gregory Chanan
>            Assignee: Arun Suresh
>         Attachments: HADOOP-11157.2.patch, HADOOP-11157.3.patch, HADOOP-11157.4.patch,
HADOOP-11157.5.patch, HADOOP-11157.6.patch, HADOOP-11157.patch, HADOOP-11157.patch
>
>
> I'm trying to integrate Solr with the DelegationTokenAuthenticationFilter and running
into this issue.  The solr unit tests look for leaked threads and when I started using the
ZKDelegationTokenSecretManager it started reporting leaks.  Shuting down the listenerThreadPool
after the objects that use it resolves the leak threads errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message